[PATCH] [Inliner][NFCI] Add an InlineSite abstraction.

[Philip Reames]

On 06/26/2015 11:53 AM, Sanjoy Das wrote:
> On Fri, Jun 26, 2015 at 12:55 AM, Chandler Carruth <chandlerc at gmail.com> wrote:
>> Started looking and really thinking about this.
>>
>> The more I think about it, the more I think that *if* we need to support inlining through statepoints, then CallSite should be able to wrap a statepoint just like it does an invoke. I don't think we want two abstractions here.
> Agreed.  Philip and I have talked about this offline, and having a
> CallSite be able to parse a gc_statepoint looks to be the right idea.
> I was planning on merging CallSite with Statepoint incrementally,
> after landing these inliner changes; but there is no real reason why
> Statepoint and CallSite cannot be combined in tree now, before these
> inliner changes go in.
I'll split a hair here: there's no *fundamental* reason this can't be 
done now.  I would prefer to see this done in the other order. Even if 
it results in a bit more churn, it's more incremental, probably easier 
to test, and gets me the InlineFunction parts I want for other purposes 
sooner.  :)

If Chandler feels strongly about this, I'll defer to him.  My preference 
is not a strong one.
>
>> But the more I think about that, the more I think that the current statepoint IR form makes that really ... icky. But I don't know if there is realistically a better one because I've not sufficiently internalized the constraints the statepoints were designed under.
>>
>> So prior to going further on this patch, I'm going to do two things to educate myself:
>>
>> 1. Chat with Sanjoy (probably in IRC) so he can teach me more about statepoints and maybe point me at the right design discussions to just go read.
>>
>> 2. Follow up on the statepoint inlining design discussion thread to ask for some more high-level details that shouldn't end up buried on this review.
>>
>>
>> http://reviews.llvm.org/D10631
>>
>> EMAIL PREFERENCES
>>    http://reviews.llvm.org/settings/panel/emailpreferences/
>>
>>