[PATCH] [lld] COFF: Implement /lldmap flag.

[Rui Ueyama]

LGTM with a few nits.


================
Comment at: COFF/Driver.cpp:604
@@ +603,3 @@
+    llvm::raw_fd_ostream Out(Arg->getValue(), EC,
+                             llvm::sys::fs::OpenFlags::F_Text);
+    if (EC) {
----------------
Add using at beginning of this file and use F_Text for consistency.

================
Comment at: COFF/Options.td:93
@@ -92,2 +92,3 @@
+def lldmap : Joined<["/", "-"], "lldmap:">;
 def lldmoduledeffile : Joined<["/", "-"], "lldmoduledeffile:">;
 
----------------
Please remove this flag since it's dead.

================
Comment at: COFF/SymbolTable.cpp:244
@@ +243,3 @@
+    for (SymbolBody *Body : File->getSymbols())
+      if (auto R = dyn_cast<DefinedRegular>(Body))
+        if (R->isLive())
----------------
auto *R = ...

http://reviews.llvm.org/D10773

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/