[PATCH] Expand Phabricator docs slightly

scott douglass sdouglass at arm.com
Fri Jun 26 10:22:05 PDT 2015


Here's a patch to the Phabricator web UI instructions in the docs that adds a couple missing button clicks and is a somewhat round-about way of asking a couple questions:
 - What is was meant by the pre-exisitng TODO?
 - Should the Repository and Project fields be used?

When I get the answers I'll update the patch.  Thanks.

http://reviews.llvm.org/D10770

Files:
  docs/Phabricator.rst

Index: docs/Phabricator.rst
===================================================================
--- docs/Phabricator.rst
+++ docs/Phabricator.rst
@@ -60,26 +60,29 @@
 To upload a new patch:
 
 * Click *Differential*.
-* Click *Create Diff*.
-* Paste the text diff or upload the patch file.
+* Click *+ Create Diff*.
+* Paste the text diff or choose the patch file. Click *Create Diff*.
   Note that TODO
+  FIXME:  What if anything should be put in the Repository field?
 * Leave the drop down on *Create a new Revision...* and click *Continue*.
 * Enter a descriptive title and summary.  The title and summary are usually
   in the form of a :ref:`commit message <commit messages>`.
 * Add reviewers and mailing
   lists that you want to be included in the review. If your patch is
-  for LLVM, add llvm-commits as a subscriber; if your patch is for Clang,
+  for LLVM, add llvm-commits as a Subscriber; if your patch is for Clang,
   add cfe-commits.
+* FIXME:  Should you use the Repository and/or Project fields?
 * Click *Save*.
 
 To submit an updated patch:
 
 * Click *Differential*.
-* Click *Create Diff*.
-* Paste the updated diff.
+* Click *+ Create Diff*.
+* Paste the updated diff or choose the updated patch file. Click *Create Diff*.
 * Select the review you want to from the *Attach To* dropdown and click
   *Continue*.
-* Click *Save*.
+* FIXME:  Should you use Repository and/or Project?
+* Add comments about the changes in the new diff. Click *Save*.
 
 Reviewing code with Phabricator
 -------------------------------

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10770.28575.patch
Type: text/x-patch
Size: 1541 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150626/f849052c/attachment.bin>


More information about the llvm-commits mailing list