[PATCH] [Inliner][NFCI] Add an InlineSite abstraction.

Chandler Carruth chandlerc at gmail.com
Fri Jun 26 00:55:22 PDT 2015


Started looking and really thinking about this.

The more I think about it, the more I think that *if* we need to support inlining through statepoints, then CallSite should be able to wrap a statepoint just like it does an invoke. I don't think we want two abstractions here.

But the more I think about that, the more I think that the current statepoint IR form makes that really ... icky. But I don't know if there is realistically a better one because I've not sufficiently internalized the constraints the statepoints were designed under.

So prior to going further on this patch, I'm going to do two things to educate myself:

1. Chat with Sanjoy (probably in IRC) so he can teach me more about statepoints and maybe point me at the right design discussions to just go read.

2. Follow up on the statepoint inlining design discussion thread to ask for some more high-level details that shouldn't end up buried on this review.


http://reviews.llvm.org/D10631

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list