[PATCH] AMDGPU/SI: Add hsa code object directives

Matt Arsenault Matthew.Arsenault at amd.com
Thu Jun 25 19:58:24 PDT 2015


LGTM


================
Comment at: lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp:71-72
@@ +70,4 @@
+
+  unsigned NameSZ = 4;
+  StringRef Name = StringRef("AMD", NameSZ);
+
----------------
You can construct it directly
StringRef Name("AMD", 4);

================
Comment at: lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp:96
@@ +95,3 @@
+  unsigned NameSZ = 4;
+  StringRef Name = StringRef("AMD", NameSZ);
+
----------------
Again

http://reviews.llvm.org/D10757

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list