[PATCH] Set a debugger "target" to guide DWARF choices
David Blaikie
dblaikie at gmail.com
Thu Jun 25 10:16:24 PDT 2015
Looks plausible. Though the command line flag should really only be used for testing, I think - you'll want another way to specify it for actual exposure through clang, etc, if you want/need to expose it.
================
Comment at: include/llvm/CodeGen/CommandFlags.h:236
@@ +235,3 @@
+cl::opt<DebuggerKind>
+DebuggerTuning("debugger-tune",
+ cl::desc("Tune debug info for a particular debugger"),
----------------
What's the command line argument for? I mean convenience of testing LLVM, a bit, but in general we don't want to use backend options like this when actually interacting with LLVM from Clang and other frontends. This should probably end up as a part of the CU debug info metadata? Or a module-level debug info metadata flag? (ala DWARF version)
================
Comment at: test/DebugInfo/X86/dwarf-public-names.ll:42
@@ -41,3 +41,3 @@
; NOPUB: debug_pubnames
-; NOPUB: {{^$}}
+; NOPUB-NEXT: {{^$}}
----------------
what happened to these two checks in this test?
http://reviews.llvm.org/D8506
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list