Switch test-release.sh to build with cmake by default (PR21561)

Daniel Sanders Daniel.Sanders at imgtec.com
Thu Jun 25 01:59:10 PDT 2015


> I removed the -build-triple option. That seems to be intended for cross-compiling and won't work with cmake. Does > anyone know if that's actually used for any of our release binaries?

The Mips releases use it to workaround to a long-standing target triple bug. The problem is that config.guess reports mips64-linux-gnu/mips64el-linux-gnu for all of my test machines. This is fine for GCC because there's no real difference between those triples and mips-linux-gnu/mipsel-linux-gnu (both _usually_ emit 32-bit code by default). Unfortunately, the triples currently have strict meanings in LLVM and mips64/mips64el triples are unable to emit the 32-bit code that is used by the rest of the installed Debian. As a result, I have to tell ./configure that the build system is really mips-linux-gnu/mipsel-linux-gnu so that it does the right thing. The work I'm doing on target triples at the moment will make it possible to fix it but the actual fix is unlikely to be ready for LLVM 3.7.

For CMake, I have to set LLVM_TARGET_ARCH, and LLVM_HOST_TRIPLE instead.

> I'm also considering removing the "do_64bit" thing, as I'm not entirely sure how that's supposed to work.

Me neither.
________________________________________
From: Hans Wennborg [hans at chromium.org]
Sent: 24 June 2015 23:01
To: thomas.stellard at amd.com; renato.golin at linaro.org; Daniel Sanders
Cc: hans at hanshq.net; llvm-commits at cs.uiuc.edu
Subject: [PATCH] Switch test-release.sh to build with cmake by default (PR21561)

Hi tstellarAMD, rengolin, dsanders,

Here is a stab at switch the release script to build with cmake instead of autoconf. It retains an option to build with autoconf for platforms where that's necessary, such as Darwin.

Here is a diff between the resulting tarballs of building 3.6.1-rc1 on Linux with the old script vs. this new version: {F589711}.

I removed the -build-triple option. That seems to be intended for cross-compiling and won't work with cmake. Does anyone know if that's actually used for any of our release binaries?

I'm also considering removing the "do_64bit" thing, as I'm not entirely sure how that's supposed to work. For me, it seems to always build two 64-bit packages. Let me know what you think.

(I will hold off committing this in any case until 3.6.2 is out the door to avoid that getting built with the wrong version script.)

http://reviews.llvm.org/D10715

Files:
  utils/release/test-release.sh

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/




More information about the llvm-commits mailing list