[PATCH] [mips] [IAS] Make .module directives change AssemblerOptions->front().
Daniel Sanders
daniel.sanders at imgtec.com
Thu Jun 25 07:41:39 PDT 2015
LGTM with a nit
================
Comment at: test/MC/Mips/update-module-level-options.s:10
@@ +9,3 @@
+ add.s $f1, $f2, $f4
+# CHECK-NOT: :[[@LINE-1]]:9: error: -mno-odd-spreg prohibits the use of odd FPU registers
+
----------------
It's probably best to be less strict on the column. This check will succeed if the error appeared for column 10 for example.
http://reviews.llvm.org/D10643
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list