[llvm] r183213 - [llvm-symbolizer] Avoid calling slow getSymbolSize for Mach-O files. Assume that symbols with zero size are in fact large enough.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Thu Jun 25 08:09:25 PDT 2015


On 24 June 2015 at 17:01, Alexey Samsonov <vonosmas at gmail.com> wrote:
>
> On Wed, Jun 24, 2015 at 1:29 PM, Rafael EspĂ­ndola
> <rafael.espindola at gmail.com> wrote:
>>
>> Would it make sense to use object::computeSymbolSizes now?
>
>
> Definitely. llvm-symbolizer has an interesting special case for ELF, though:
> if regular symbol table is missing,
> we iterate over dynamic symbol table, and call getSymbolSize() for each
> symbol from there. Do you think we
> should add smth. like computeDynamicSymbolSizes?

Sure, NP.

r240646.

Cheers,
Rafael




More information about the llvm-commits mailing list