[PATCH] [PPC] Implement vmrgew and vmrgow instructions
Bill Schmidt
wschmidt at linux.vnet.ibm.com
Wed Jun 24 15:32:05 PDT 2015
Other than a nit in the test case commentary, this LGTM. Thanks for handling this very confusing stuff and documenting it well!
================
Comment at: test/CodeGen/PowerPC/vec_mergeow.ll:36
@@ +35,3 @@
+; vmrgow instruction. Note also that on little endian the input registers
+; are swapped also.
+define void @check_merge_even_xx(<16 x i8>* %A) {
----------------
In this case, the swapped input registers comment doesn't matter.
================
Comment at: test/CodeGen/PowerPC/vec_mergeow.ll:85
@@ +84,3 @@
+; vmrgew instruction. Note also that on little endian the input registers
+; are swapped also.
+define void @check_merge_odd_xx(<16 x i8>* %A) {
----------------
Same comment here.
http://reviews.llvm.org/D10704
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list