[PATCH] [Inlining][NFC] Introduce a InlineFunction that takes a Statepoint.

Philip Reames listmail at philipreames.com
Wed Jun 24 12:02:41 PDT 2015


Forgot to say in my previous review, but I think you need to find a way to test this.  Used code is not really NFC, it's just unused.  I know you're planning on building on this with related patches, but this is big enough it should be tested on it's own.

One suggestion: You could restructure PlaceSafepoints to convert to insert statepoints for gc polls, then inline using the new functionality.  Anything that exercises this is fine by me.


http://reviews.llvm.org/D10632

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list