[PATCH] One more change required to build the sanitizers for iOS.

Alexey Samsonov vonosmas at gmail.com
Wed Jun 24 11:16:59 PDT 2015


All this looks weird to me.

1. Slow unwind is not available on Mac at all (see `SANITIZER_CAN_SLOW_UNWIND` macro).
2. You #ifdef out BufferedStackTrace methods which are referenced from other files (`sanitizer_stacktrace_libcdep.cc`)
3. You don't #ifdef out another _Unwind-related helper methods like `Unwind_Trace`, `Unwind_GetIP`, which are only used in functions you #ifdef out.

Looks like this whole *file* makes no sense on Mac, as we're not using slow unwinder there. I'd suggest we just rename it to smth. like `sanitizer_unwind_linux_libcdep.cc`, and use it on Linux/Android/FreeBSD only.


http://reviews.llvm.org/D10696

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list