[PATCH] Add NVPTXPeephole pass to reduce unnecessary address cast

Justin Holewinski justin.holewinski at gmail.com
Wed Jun 24 04:48:10 PDT 2015


What is the future expectation for NVPTXPeephole?  Are you planning on adding additional transforms?  If not, perhaps a more specific name is warranted.  Otherwise, LGTM!  Thanks!


================
Comment at: lib/Target/NVPTX/NVPTXPeephole.cpp:7
@@ +6,3 @@
+// License. See LICENSE.TXT for details.
+//
+// In NVPTX, NVPTXFrameLowering will emit following instruction at the beginning
----------------
Missing separator, e.g.

//===----------------------------------------------------------------------===//

================
Comment at: lib/Target/NVPTX/NVPTXRegisterInfo.td:68
@@ -67,3 +67,3 @@
 // Read NVPTXRegisterInfo.cpp to see how VRFrame and VRDepot are used.
-def SpecialRegs : NVPTXRegClass<[i32], 32, (add VRFrame, VRDepot,
+def SpecialRegs : NVPTXRegClass<[i32], 32, (add VRFrame, VRFrameLocal, VRDepot,
                                             (sequence "ENVREG%u", 0, 31))>;
----------------
Good catch!

http://reviews.llvm.org/D10549

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list