[PATCH] [LLD] COFF: Make link order compatible with MSVC link.exe.

[Peter Collingbourne]

LGTM with my suggested change.


================
Comment at: COFF/SymbolTable.cpp:293
@@ +292,3 @@
+
+  size_t End = BitcodeFiles.end();
+  if (auto EC = run())
----------------
ruiu wrote:
> pcc wrote:
> > Huh, does this compile? `BitcodeFiles.end()` is an iterator, right?
> Ah, sorry, I intended to write auto instead of size_t. (And if we make that change, all tests pass.)
I don't think it is correct to compare iterators like this because the standard library may invalidate iterators if elements are appended to the vector. Can we make this use `size` as before?

http://reviews.llvm.org/D10672

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/