[PATCH] [LLD] COFF: Make link order compatible with MSVC link.exe.

Peter Collingbourne peter at pcc.me.uk
Tue Jun 23 16:37:28 PDT 2015


================
Comment at: COFF/SymbolTable.cpp:292
@@ -288,1 +291,3 @@
+      addMemberFile(B);
+      if (auto EC = run())
         return EC;
----------------
If we move the call to run() below this loop, it should make the code a little easier to reason about, as run() will never see a symbol table that has only been partially processed by the loop.

================
Comment at: test/COFF/order.test:1
@@ +1,2 @@
+# RUN: yaml2obj < %p/Inputs/include1a.yaml > %t1.obj
+# RUN: yaml2obj < %p/Inputs/include1b.yaml > %t2.obj
----------------
Did you forget to add these input files?

http://reviews.llvm.org/D10672

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list