[PATCH] Working on reconciling out-of-tree patches to compiler-rt for building for iOS.

Alexey Samsonov vonosmas at gmail.com
Tue Jun 23 14:12:19 PDT 2015


LGTM, though I really think we should move _NSGetEnviron logic to a function.


================
Comment at: lib/sanitizer_common/sanitizer_mac.cc:200
@@ -194,2 +199,3 @@
+#if !SANITIZER_IOS
   char ***env_ptr = _NSGetEnviron();
   if (!env_ptr) {
----------------
We have similar code in asan_mac.cc. Please consider factoring it to a function, which we could call from there instead.

http://reviews.llvm.org/D10510

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list