[PATCH] Working on reconciling out-of-tree patches to compiler-rt for building for iOS.

[Alexey Samsonov]

LGTM (provided SANITIZER_IOS and SANITIZER_IOSSIM would be made mutually exclusive).


================
Comment at: lib/asan/asan_mac.cc:28
@@ +27,3 @@
+#if !SANITIZER_IOS
+#include <crt_externs.h>  // for _NSGetArgv and _NSGetEnviron
+#else
----------------
beanz wrote:
> samsonov wrote:
> > How did this #include for SANITIZER_IOSSIM before this change?
> crt_externs.h exists in the iOS Simulator SDK, but not in the device SDK... Don't ask. I have no answers.
That's fine, but doesn't this mean we should keep #including <crt_externs.h> on iossim?
I'd actually vote for making SANITIZER_IOS and SANITIZER_IOSSIM exclusive. In this case we won't have to care about correct order of #elif clauses in asan_mapping.h

http://reviews.llvm.org/D10515

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/