[PATCH] Working on reconciling out-of-tree patches to compiler-rt for building for iOS.

Chris Bieneman beanz at apple.com
Tue Jun 23 11:11:17 PDT 2015


================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_posix.cc:55
@@ -56,1 +54,3 @@
 
+#if !SANITIZER_IOS
+#include <net/if_arp.h>
----------------
samsonov wrote:
> Any specific reason to move #include directives down here?
It was moved down for consistency with how Android and Linux handled special include handling.

================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_posix.cc:344
@@ -340,1 +343,3 @@
+#if !SANITIZER_IOS
   unsigned struct_arpreq_sz = sizeof(struct arpreq);
+#endif
----------------
samsonov wrote:
> Where do you get this constant from on iOS?
These patches are about making it build, not function. Anna will be working on patches to make it function, but that is outside of what I'm able to handle here.

http://reviews.llvm.org/D10514

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list