[PATCH] __tsan::ThreadCreate takes incorrect value for detached argument

Alexander Potapenko glider at google.com
Tue Jun 23 09:52:47 PDT 2015


+dvyukov
LGTM


================
Comment at: lib/tsan/rtl/tsan_interceptors.cc:42
@@ +41,3 @@
+#if SANITIZER_LINUX || SANITIZER_FREEBSD
+#define PTHREAD_CREATE_JOINABLE 0
+#define PTHREAD_CREATE_DETACHED 1
----------------
I don't think you need the definition of PTHREAD_CREATE_JOINABLE, since nobody's using it.

http://reviews.llvm.org/D10606

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list