[PATCH] [ARM]: Extend -mfpu options for half-precision and vfpv3xd

Renato Golin renato.golin at linaro.org
Tue Jun 23 07:14:16 PDT 2015


Hi Javed,

You somehow overrode the previous patch. You should commit tests with the patch, not as separate.

Even if you keep them as separate patches in git (I usually do), when sending to Phab you need to diff against master (git diff -U999 master > patch), so that Phab can track it correctly.

Also, about vfpv3xd, what I mean is that we don't differentiate vfpv3 from vfpv3xd, so there's no point in having a new enum value for it. If it's just an alias, then you can add it to the table, but map it to FK_VFPV3_D16 and FK_VFPV3_D16_FP16.

Unless it really makes a difference if you want to get the *same* string back later for (say) the assembler or linker. Since we have no use at all of that tag in the whole of LLVM+Clang codebase, I don't think adding it here makes any sense without a strong reason, which can (and should) be tested.

cheers,
--renato


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D10645

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list