[PATCH] Extending Vector GetElementPtr - please review
hfinkel at anl.gov
hfinkel at anl.gov
Mon Jun 22 19:13:47 PDT 2015
Can you please separate out the masked.store changes?
Please also include the LangRef update with this patch; they should not be separate.
REPOSITORY
rL LLVM
================
Comment at: include/llvm/IR/Instructions.h:842
@@ -840,1 +841,3 @@
+ assert(PointeeType ==
+ cast<PointerType>(Ptr->getType()->getScalarType())->getElementType()->getScalarType());
else
----------------
Line too long? (looks like there are a bunch of these)
================
Comment at: include/llvm/IR/Instructions.h:978
@@ -973,2 +977,3 @@
}
-
+ else
+ for (Value *Index : IdxList)
----------------
Don't add an else after a return.
http://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return
http://reviews.llvm.org/D10496
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list