[PATCH] Expand loop reroll to handle loop with multiple induction variables and negative increment

[hfinkel at anl.gov]

Please enhance your patch description to explain, not just what he patch enables (which you've done), but generically how it does it. There is a bunch of new code here, and it will be good to get a high-level overview of what it does (and I'd expect such a description to appear in the commit message anyway, so this is not "just for review").

Please upload the patch with full context, see:

  http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

for instructions.


REPOSITORY
  rL LLVM

================
Comment at: lib/Transforms/Scalar/LoopRerollPass.cpp:447
@@ +446,3 @@
+
+    bool isCompareInsn(Instruction *I, BasicBlock *Header) {
+      Instruction *Branch = dyn_cast<BranchInst>(Header->getTerminator());
----------------
We generally abbreviate Instruction to Inst, not Insn. Please rename this function.

Also, please comment what this function does. It is certainly more than just determining if the instruction is a comparison of some kind.

http://reviews.llvm.org/D10477

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/