[PATCH] Fix bug 23851: Preserve metadata for the unswitched branch in loop-unswitch

hfinkel at anl.gov hfinkel at anl.gov
Mon Jun 22 17:59:23 PDT 2015


================
Comment at: lib/Transforms/Scalar/LoopUnswitch.cpp:693
@@ -687,1 +692,3 @@
 
+static void copyMetaData(Instruction *DstInst, const Instruction *SrcInst,
+                         bool Swapped) {
----------------
Please name this
  copyMetadata
the convention is not to capitalize the d.


================
Comment at: lib/Transforms/Scalar/LoopUnswitch.cpp:720
@@ +719,3 @@
+        }
+      }
+    case LLVMContext::MD_dbg:
----------------
I'd prefer there be a
  // fallthrough
comment here.

http://reviews.llvm.org/D10458

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list