[patch] MCSymbols for FastISel

Pete Cooper peter_cooper at apple.com
Mon Jun 22 12:36:46 PDT 2015


> On Jun 22, 2015, at 12:14 PM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
> 
> This is basically a leftover from my previous patch.
> 
> The summary is that it moves the mangling earlier and replaces a few
> calls to .addExternalSymbol with addSym.
> 
> I originally wanted to replace all the uses of addExternalSymbol with
> addSym, but noticed it was not needed for the previous patch and that
> it was a lot of work.
> 
> I still think it would be a good thing. This patch is just the part I
> already had implemented.
Yeah, this all makes sense.

Only bit i wasn’t sure about is the formatting of this.  Can you please double check it with clang-format.  Otherwise, LGTM.

+FastISel::CallLoweringInfo &FastISel::CallLoweringInfo::setCallee(
+    const DataLayout &DL, MCContext &Ctx, CallingConv::ID CC, Type *ResultTy,
+    const char *Target, ArgListTy &&ArgsList, unsigned FixedArgs) {

Cheers,
Pete
> 
> Cheers,
> Rafael
> <t.patch>





More information about the llvm-commits mailing list