[PATCH] Use function attribute "arm-restrict-it"

Akira Hatanaka ahatanak at gmail.com
Mon Jun 22 11:22:38 PDT 2015


In http://reviews.llvm.org/D10416#191108, @rengolin wrote:

> In http://reviews.llvm.org/D10416#191097, @echristo wrote:
>
> > We've always had two options for this sort of thing, just much more
> >  horribly implemented. :)
>
>
> I see. It is hidden, and it has the exact same behaviour (tri-state, isARMv8() on default, implemented in the same function), so I guess it's ok.
>
> The chances that people will abuse of this relationship or will change one and not the other is indeed, minimal.


Since this is intended to be used only by tools such as llc and opt, we can move the IT option to CodeGen/CommandFlags.h and let setFunctionAttributes rewrite the function attribute in the IR. The downside of this is that we'll be moving a target-specific option into a file that is supposed to be target-independent.


http://reviews.llvm.org/D10416

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list