[PATCH] [Polly] Prepare replacing ISL by its 'make dist' files.

Michael Kruse llvm at meinersbur.de
Mon Jun 22 08:49:12 PDT 2015


Hi grosser,

Currently the Polly repository contains the ISL sources with bogus isl_config.h and gitversion.h. This is problematic. In this state a macro

   #define __attribute__(x)

becomes active in the source, leading to various problems e.g. when included before system header files. This patch will instead generate the two files specific to the host system at configure-time.

For CMake, we replicate the tests that ISL's configure performs using try_compile(). In autotools build, we just invoke ISL's configure to generate the two files. This consequently required regenerating autoconf/configure.

'make dist' distributions of ISL contain a file GIT_HEAD_ID which contains the version the distribution is derived from. The repository files themselves do not contain such a hint. In a later commit we will replace the isl directory by the contents of such a .tar.gz. It does not contain the files imdrover.c iprime.c pi.c and rsamath.c currently compiled into Polly, but not used and therefore are removed by this patch.

In the long term we plan to generate a dedicated library for ISL instead of adding its files to Polly.

This also does not yet include the switch to small-integer optimized ISL nor enabling C99 mode required for the former. Those will come as well in separate patches.

http://reviews.llvm.org/D10603

Files:
  Makefile.config.in
  autoconf/configure.ac
  configure
  lib/CMakeLists.txt
  lib/External/gitversion.h.cmake
  lib/External/isl_config.h.cmake
  lib/Makefile

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10603.28114.patch
Type: text/x-patch
Size: 11228 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150622/a50da23c/attachment.bin>


More information about the llvm-commits mailing list