[PATCH] [ARM] ARMLoadStoreOpt::UpdateBaseRegUses should stop on def
John Brawn
john.brawn at arm.com
Mon Jun 22 04:28:44 PDT 2015
In http://reviews.llvm.org/D10566#191185, @MatzeB wrote:
> Nice catch! Kill flags are indeed optional nowadays so the additional check for definesRegister is necessary. Do you happen to have a llvm-lit testcase that exposes the bug?
I have a .ll file that exposes the bug but it's ~150 lines long and generates assembly that's ~450 lines long, with the incorrectly-generated code sequence in the middle which is rather infeasible to test. I haven't been able to reduce it to produce a sensible test case - it looks like it's a very specific combination of regalloc and post-regalloc optimization that produces the input to the load/store optimizer that triggers the bug.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D10566
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list