[PATCH] Use function attribute "arm-restrict-it"
Saleem Abdulrasool
compnerd at compnerd.org
Fri Jun 19 19:02:22 PDT 2015
================
Comment at: lib/Target/ARM/ARMSubtarget.cpp:320
@@ -330,1 +319,3 @@
+bool ARMSubtarget::restrictIT(const Function &F) const {
+ // The default behavior is to disallow generation of deprecated IT blocks
----------------
Bikeshedding: I think that restrictedIT might be a better name. IIRC, the ARM ARM refers to this as Restricted IT Blocks.
================
Comment at: test/CodeGen/Thumb2/restict-it-fnattr.ll:12
@@ +11,3 @@
+; RESTRICT-IT-LABEL: {{\_?}}no_restrict_it:
+; RESTRICT-IT: it{{ }}
+
----------------
This test slightly concerns me. With Restricted IT blocks, IT blocks are only constructed under certain circumstances on ARMv7. Do you mind adding a bit more context around the test by adding -NEXT checks to ensure that the instructions within the IT blocks are exactly what we expect?
http://reviews.llvm.org/D10416
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list