[PATCH] Add support for complex aggregate store in InstCombine

Amaury SECHET deadalnix+llvmreview at gmail.com
Fri Jun 19 16:52:44 PDT 2015


Rebased that diff on top of existing master. I'd really like to get that moving. I'm aware of the concern voiced by @majnemer , however

- No better solution is on the table by now. Asking for something better is ok, but just letting the thing hang around is just poor code review management.
- The proposed combination is at least understood by most of the toolchain, when fca are not. That is just dumb to reject an improvement simply for the foggy hope of some better improvement that is never comming.

I do think I have proven to be sticking around and can be trusted to continue work on that in the future. inf act, the process has been so slow that pretty much anyone would have given up by now.

It's been a month that this is just sitting there. You guys need to provide a way forward to get it as it is. I just can't reimplement that in a new way every 2 month because nobody has any clue how to move forward on the subject. This is disrespectful of my work and hurtful for the project at large as you can't get a better strategy to get contributor pissed of.


http://reviews.llvm.org/D9766

Files:
  lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
  test/Transforms/InstCombine/unpack-fca.ll

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D9766.28062.patch
Type: text/x-patch
Size: 13241 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150619/5e6e1320/attachment.bin>


More information about the llvm-commits mailing list