[PATCH] Add control flow integrity diagnosis function to UBSan runtime library.

Alexey Samsonov vonosmas at gmail.com
Thu Jun 18 17:51:58 PDT 2015


LGTM


================
Comment at: test/cfi/lit.cfg:12
@@ -11,2 +11,3 @@
 if config.lto_supported:
-  config.substitutions.append((r"%clangxx_cfi ", ' '.join(config.lto_launch + [clangxx] + config.lto_flags + ['-fsanitize=cfi '])))
+  clangxx_cfi = ' '.join(config.lto_launch + [clangxx] + config.lto_flags + ['-fsanitize=cfi '])
+  config.substitutions.append((r"%clangxx_cfi ", clangxx_cfi))
----------------
I think it would be easier to construct list of args for clangxx_cfi, and clangxx_cfi_diag, and then do `' '.join(...)` for both of them. Leaving this up to you, though.

http://reviews.llvm.org/D10269

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list