[llvm] r239943 - AMDGPU: Change unreachable into reported error

[David Blaikie]

On Wed, Jun 17, 2015 at 6:51 PM, Matt Arsenault <arsenm2 at gmail.com> wrote:

>
> On Jun 17, 2015, at 6:35 PM, Rafael Espíndola <rafael.espindola at gmail.com>
> wrote:
>
> Is it testable?
>
>
> Not really. The testcase would be pretty big, and it shouldn’t really ever
> happen unless there’s a bug somewhere.
>

Eh - if it's always a bug (& thus untestable), I'd be inclined not to
support it, even as an error path. That's what assertion failures, etc, are
for. (opinions may differ, though)


> Getting this wrong isn’t going to break the compiler somewhere, so I don’t
> think it should crash and only report that the resulting program probably
> won’t work correctly.
>
> -Matt
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150618/8c1f7e5a/attachment.html>