[PATCH] [FaultMaps] Add a parser for the __llvm__faultmaps section.

[Rafael Ávila de Espíndola]

I have no objections (just small comments), but lhames should probably be the one to give the final OK.


================
Comment at: test/CodeGen/X86/implicit-null-check.ll:2
@@ -1,1 +1,3 @@
 ; RUN: llc -O3 -mtriple=x86_64-apple-macosx -enable-implicit-null-checks < %s | FileCheck %s
+; RUN: llc -O3 -mtriple=x86_64-apple-macosx -enable-implicit-null-checks < %s -filetype=obj -o - | llvm-objdump -fault-map-section - | FileCheck %s -check-prefix=OBJDUMP
+; RUN: llc -O3 -mtriple=x86_64-unknown-linux-gnu -enable-implicit-null-checks < %s -filetype=obj -o - | llvm-objdump -fault-map-section - | FileCheck %s -check-prefix=OBJDUMP
----------------
Do you really need to use llc? Can't you use llvm-mc or even check in a binary?

================
Comment at: test/CodeGen/X86/implicit-null-check.ll:3
@@ -2,1 +2,3 @@
+; RUN: llc -O3 -mtriple=x86_64-apple-macosx -enable-implicit-null-checks < %s -filetype=obj -o - | llvm-objdump -fault-map-section - | FileCheck %s -check-prefix=OBJDUMP
+; RUN: llc -O3 -mtriple=x86_64-unknown-linux-gnu -enable-implicit-null-checks < %s -filetype=obj -o - | llvm-objdump -fault-map-section - | FileCheck %s -check-prefix=OBJDUMP
 
----------------
These are both little endian. Your code is templated on endiannes, so you should probably include a big endian test.

http://reviews.llvm.org/D10491

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/