[PATCH] CMake: Stop using LLVM's custom parse_arguments. NFC

Filipe Cabecinhas filcab+llvm.phabricator at gmail.com
Wed Jun 17 22:01:35 PDT 2015


Hi eugenis, samsonov, beanz,

Use CMake's cmake_parse_arguments() instead.
It's called in a slightly different way, but supports all our use cases.
It's in CMake 2.8.8, which is our minimum supported version.

CMake 3.0 doc (roughly the same. No direct link to 2.8.8 doc):
http://www.cmake.org/cmake/help/v3.0/module/CMakeParseArguments.html?highlight=cmake_parse_arguments

Since I was already changing these calls, I changed ARCH and LIB into
ARCHS and LIBS to make it more clear that they're lists of arguments.

http://reviews.llvm.org/D10529

Files:
  cmake/Modules/AddCompilerRT.cmake
  cmake/Modules/CompilerRTCompile.cmake
  cmake/Modules/CompilerRTLink.cmake
  cmake/Modules/SanitizerUtils.cmake
  lib/asan/CMakeLists.txt
  lib/asan/tests/CMakeLists.txt
  lib/interception/CMakeLists.txt
  lib/lsan/CMakeLists.txt
  lib/msan/tests/CMakeLists.txt
  lib/sanitizer_common/CMakeLists.txt
  lib/tsan/dd/CMakeLists.txt
  lib/tsan/tests/CMakeLists.txt
  lib/ubsan/CMakeLists.txt

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10529.27912.patch
Type: text/x-patch
Size: 16686 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150618/3641e3b5/attachment.bin>


More information about the llvm-commits mailing list