[PATCH] [SPARC] Repair GOT references to internal symbols.

James Y Knight jyknight at google.com
Wed Jun 17 19:08:30 PDT 2015


================
Comment at: test/CodeGen/SPARC/obj-relocs.ll:1
@@ -1,2 +1,2 @@
 ; RUN: llc < %s -march=sparcv9 -filetype=obj --relocation-model=static | llvm-readobj -r | FileCheck %s --check-prefix=CHECK-ABS
 ; RUN: llc < %s -march=sparcv9 -filetype=obj --relocation-model=pic    | llvm-readobj -r | FileCheck %s --check-prefix=CHECK-PIC
----------------
rafael wrote:
> Could this be changed to used llvm-mc? If not, what asm parsing feature that is missing?
> 
> It can be done in another commit, but we should get to it.
llvm-mc is tested in the other test case changed here. But, having a case for directly emitting relocs separate from going through textual asm is valuable, at the least because the "%hi" asm directive can parse into 3 different relocation types, depending on context. It'd be entirely plausible to have a bug that outputs an incorrect relocation in direct object writing, but have it turn out right after going through asm serialization/parsing.

http://reviews.llvm.org/D10441

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list