[PATCH] MIR Serialization: Serialize machine instruction names.

Ahmed Bougacha ahmed.bougacha at gmail.com
Wed Jun 17 16:45:33 PDT 2015


REPOSITORY
  rL LLVM

================
Comment at: lib/CodeGen/MIRPrinter.cpp:115
@@ -86,1 +114,3 @@
+
+  OS << StringRef(TII->getName(MI.getOpcode())).lower();
 }
----------------
Why lower-case?  I'd much prefer the exact same as the C++/MI enums/names.  And if no one else does this lowercasing already (I don't think so), this can introduce ambiguity (it will).

http://reviews.llvm.org/D10481

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list