[PATCH] [ExecutionEngine][MCJIT] Add a freeGeneratedCode hook.
Sanjoy Das
sanjoy at playingwithpointers.com
Wed Jun 17 14:00:09 PDT 2015
> How does this differ from destroying the execution engine altogether
> and creating a new one?
In terms of what it does, I do not think that calling
freeGeneratedCode is very different from destroying and re-creating
the execution engine. But creating a new execution engine, compiling
a module, and immediately destroying it for every compile[1] did not
feel like the right semantic model (it does strictly more than I need
MCJIT to do, and can paper over other lifetime issues).
If you think this create-and-destroy option is the more reasonable
than adding a freeGeneratedCode hook then I can try to get that to
work with our VM and see how that goes.
-- Sanjoy
[1]: We copy out generated code into our custom code arena, so keeping
a second copy of the generated code in MCJIT's memory manager is
unnecessary once the code has been copied out.
On Wed, Jun 17, 2015 at 11:31 AM, Lang Hames <lhames at gmail.com> wrote:
> Hi Sanjoy,
>
> Sorry for the delay on this review.
>
> How does this differ from destroying the execution engine altogether and creating a new one?
>
> - Lang.
>
>
> http://reviews.llvm.org/D10378
>
> EMAIL PREFERENCES
> http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
More information about the llvm-commits
mailing list