[PATCH] [ARM] Look through concat when lowering in-place shuffles (VZIP, ..)

Quentin Colombet qcolombet at apple.com
Wed Jun 17 11:04:15 PDT 2015


Hi Ahmed,

LGTM with some improvements on the tests patterns.

If you really really are motivated, you could fix all the patterns in a subsequent commit :).

Cheers,
-Quentin


================
Comment at: test/CodeGen/ARM/vtrn.ll:17
@@ +16,3 @@
+;CHECK-LABEL: vtrni8_Qres:
+;CHECK: vtrn.8
+	%tmp1 = load <8 x i8>, <8 x i8>* %A
----------------
I know this is consistent with the surrounding tests, but I would prefer that we check that the arguments are what we expect. In other words, could you check that we are feeding the right arguments here?

http://reviews.llvm.org/D10424

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list