[PATCH] [Zorg] Adding test-suite to CMake ClangBuilder

Reid Kleckner rnk at google.com
Wed Jun 17 10:58:05 PDT 2015


I'm OK leaving this as one function.


================
Comment at: zorg/buildbot/builders/ClangBuilder.py:686-688
@@ +685,5 @@
+        # Get generated python, lnt
+        python=WithProperties('%(workdir)s/test/sandbox/bin/python')
+        lnt=WithProperties('%(workdir)s/test/sandbox/bin/lnt')
+        lnt_setup=WithProperties('%(workdir)s/test/lnt/setup.py')
+
----------------
These assignments and others are still not using spaces. I think it bothers me because when you do it like this I assume it's part of a sequence of kwargs and I go looking for a function call to match it up with.

http://reviews.llvm.org/D10244

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list