[llvm] r239872 - Fix alignment issues in LLVM.
Justin Bogner
mail at justinbogner.com
Tue Jun 16 22:40:40 PDT 2015
James Y Knight <jyknight at google.com> writes:
> On Tue, Jun 16, 2015 at 11:07 PM, Justin Bogner <mail at justinbogner.com> wrote:
>
> James Y Knight <jyknight at google.com> writes:
> > +static_assert(AlignOf<FunctionType>::Alignment >= AlignOf<Type
> *>::Alignment,
> > + "Alignment sufficient for objects appended to
> FunctionType");
>
> I find these assert messages a bit hard to parse. It's better to have
> the message be a sentence describing what's wrong, rather than a
> statement about what's expected.
>
> Sure thing. Proposal:
> "Alignment is insufficient for objects appended to FunctionType"
I like it
More information about the llvm-commits
mailing list