[llvm] r239858 - Return a unique_ptr from getLazyBitcodeModule and parseBitcodeFile. NFC.
David Blaikie
dblaikie at gmail.com
Tue Jun 16 15:53:29 PDT 2015
On Tue, Jun 16, 2015 at 3:41 PM, Rafael EspĂndola <
rafael.espindola at gmail.com> wrote:
> >> - return std::unique_ptr<Module>(ModuleOrErr.get());
> >> + return std::move(ModuleOrErr.get());
> >
> >
> > You could probably just "return ModuleOrErr;" here?
> >
>
>
> No:
>
> IRReader.cpp:44:12: error: no viable conversion from
> 'ErrorOr<std::unique_ptr<Module> >' to 'std::unique_ptr<Module>'
>
Ah, right, sorry - missed the 'get()'.
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150616/a7e13263/attachment.html>
More information about the llvm-commits
mailing list