[PATCH] [lld] [ELF/x86_64] Fix initial-exec TLS access
Rui Ueyama
ruiu at google.com
Tue Jun 16 15:08:11 PDT 2015
LGTM with these minor fixes.
================
Comment at: lib/ReaderWriter/ELF/X86_64/X86_64ExecutableWriter.h:43
@@ +42,3 @@
+ atom->_virtualAddr, atom);
+ continue;
+ }
----------------
You can remove this continue.
================
Comment at: lib/ReaderWriter/ELF/X86_64/X86_64SectionChunks.cpp:19
@@ +18,3 @@
+ TargetLayout<ELF64LE>::ORDER_GOT)
+{
+ this->_alignment = 8;
----------------
Move { to the end of the last line.
================
Comment at: lib/ReaderWriter/ELF/X86_64/X86_64TargetHandler.h:33
@@ +32,3 @@
+ TargetLayout<ELF64LE>::SectionOrder order) override
+ {
+ if (type == DefinedAtom::typeGOT && name == ".got")
----------------
Ditto
http://reviews.llvm.org/D10479
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list