[PATCH] [InstCombine] Propagate non-null facts to call parameters

Pete Cooper peter_cooper at apple.com
Mon Jun 15 18:05:23 PDT 2015


Sorry, Phab is acting up for me, hence email.

I think this line should actually set 'Changed = true;’ and not return.  That way you can handle more than a single nonnull at a time.

+      return CS.getInstruction();

Otherwise LGTM.

Cheers,
Pete
> On Jun 15, 2015, at 5:48 PM, Philip Reames <listmail at philipreames.com> wrote:
> 
> REPOSITORY
>  rL LLVM
> 
> http://reviews.llvm.org/D9132
> 
> Files:
>  llvm/trunk/include/llvm/IR/CallSite.h
>  llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp
>  llvm/trunk/test/CodeGen/NVPTX/intrin-nocapture.ll
>  llvm/trunk/test/Transforms/Inline/byval-tail-call.ll
>  llvm/trunk/test/Transforms/InstCombine/nonnull-param.ll
>  llvm/trunk/test/Transforms/InstCombine/select.ll
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> <D9132.27738.patch>





More information about the llvm-commits mailing list