[PATCH] Teach InlineCost to account for a null check which can be folded away

[Philip Reames]

Two weeks ago, I brought a copy of this review to the social and got review comments from Chandler in person.

He mentioned two minor issues:

1. A helper function should be abstracted for the non-null handling since it now makes up a large part of the function.
2. The comments need to emphasize that this is about accessing attributes at the *callsite* more clearly.

I'm about to upload a patch with both of these addressed.

He also expressed concern over the fact that the CallSite (and thus possibly the caller) was exposed to ICA.  His concern wasn't w.r.t. to this change per se, but whether a future change might build on this one in a way which would make caching inline cost analysis in the future more difficult.  He stated he needed more time to consider the mater before making up his mind on review feedback.

Chandler - Have you come to any conclusions?


http://reviews.llvm.org/D9129

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/