[PATCH] [ARM] Keep track of previous changes to the bit pattern stored HW_FP

[Ranjeet Singh]

> > Can you explain in more detail how I can check for this internal bug using CHECK-DAG?

> 

> 

> I'm assuming this is the target features, that normally come in the format:

> 

>   +foo,-bar,+baz

>    

> 

> or

> 

>   -target-feature +foo -target-feature -bar -target-feature +baz

>    

> 

> Either case, if you use:

> 

>   CHECK-DAG: +foo

>   CHECK-DAG: -bar

>   CHECK-DAG: +baz

>    

> 

> They could come in any order and it would still match.


Do you mean matching against the -cc1 command line?  There's no way for a test case to determine in which order the features come out of the StringMap and are processed.  Changing the order on the -cc1 command line may still process the features in the same order.  So I don't see how to write a test case that ensures the old code fails.


http://reviews.llvm.org/D10395

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/