[llvm] r239692 - AsmPrinter.cpp: Avoid crashes for targeting like "arm-mingw32". CurrentFnSym might not be <MCSymbolELF> here.

Rafael Espíndola rafael.espindola at gmail.com
Sun Jun 14 06:09:58 PDT 2015


Testcase?
On Jun 13, 2015 8:31 PM, "NAKAMURA Takumi" <geek4civic at gmail.com> wrote:

> Author: chapuni
> Date: Sat Jun 13 19:23:40 2015
> New Revision: 239692
>
> URL: http://llvm.org/viewvc/llvm-project?rev=239692&view=rev
> Log:
> AsmPrinter.cpp: Avoid crashes for targeting like "arm-mingw32".
> CurrentFnSym might not be <MCSymbolELF> here.
>
> Modified:
>     llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
>
> Modified: llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp?rev=239692&r1=239691&r2=239692&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp (original)
> +++ llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp Sat Jun 13 19:23:40
> 2015
> @@ -902,7 +902,8 @@ void AsmPrinter::EmitFunctionBody() {
>      const MCExpr *SizeExp = MCBinaryExpr::createSub(
>          MCSymbolRefExpr::create(CurrentFnEnd, OutContext),
>          MCSymbolRefExpr::create(CurrentFnSymForSize, OutContext),
> OutContext);
> -    OutStreamer->emitELFSize(cast<MCSymbolELF>(CurrentFnSym), SizeExp);
> +    if (auto Sym = dyn_cast<MCSymbolELF>(CurrentFnSym))
> +      OutStreamer->emitELFSize(Sym, SizeExp);
>    }
>
>    for (const HandlerInfo &HI : Handlers) {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150614/67df17d6/attachment.html>


More information about the llvm-commits mailing list