[PATCH] [PM/AA] Split the location computation out of getArgLocation so the virtual interface on AliasAnalysis only deals with ModRef information.

[hfinkel at anl.gov]

I want to make sure that I understand where we'd like this to go. So currently, suppose you have a language with a runtime library ( ;) ), it is currently possible to add a custom AA pass that will provide argument memory-location information for those library calls. With this refactoring, this seems no longer possible.

I'm unclear on where we'd like this information to live (AA, TLI, etc.), but I think we need the ability to add this information for known functions without modifying core LLVM code. If we had a proper extensibility scheme for TLI (which, IMHO, we need regardless), maybe TLI would be the more-natural place?


================
Comment at: lib/Analysis/MemoryLocation.cpp:93
@@ +92,3 @@
+
+// FIXME: This code is duplicated with BasicAliasAnalysis and should be hoisted
+// to some common utility location.
----------------
Should this kind of thing live in TLI?

http://reviews.llvm.org/D10259

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/