[PATCH] Fix PR 23525 - Separate header mass propagation in irregular loops.

Duncan P. N. Exon Smith dexonsmith at apple.com
Fri Jun 12 13:20:13 PDT 2015


> On 2015-Jun-12, at 13:19, Diego Novillo <dnovillo at google.com> wrote:
> 
> 
> 
> On Fri, Jun 12, 2015 at 4:11 PM, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
> 
> Okay, I finally caught up with the rest of the thread.  Looks like
> David noticed the same thing I did.  (Sorry for my delay coming back to
> this.)
> 
> I agree that doing it separately is fine, as long as there aren't any
> regressions in LNT.  I doubt there will be, since I don't think we have
> much irreducible control flow there.
> 
> Been running tests the last couple of days. SPEC, our internal benchmarks and LNT. No regressions anywhere. Irreducible control flow is rare, so I wasn't expecting any difference.
> 
> If you're OK with this, I'll address the changes you wanted and commit.  I'll follow up with the patch to also account for incoming edge masses.
> 

SGTM.  Thanks for working on it.





More information about the llvm-commits mailing list