[PATCH] Add 'shave' processor name to Triple

Chandler Carruth chandlerc at gmail.com
Fri Jun 12 11:13:31 PDT 2015


LGTM with minor tweak to wording.

You should also mention in the commit log when you submit this that the purpose initially is just to allow Clang to process these triples and redirect compilation to the Movidius dev kit.


================
Comment at: include/llvm/ADT/Triple.h:87
@@ -86,2 +86,3 @@
     kalimba,    // Kalimba: generic kalimba
-    LastArchType = kalimba
+    shave,      // SHAVE: Movidius SoC
+    LastArchType = shave
----------------
I don't think this is really the SoC.

I would say: "SHAVE: Movidius Myriad 2 vector VLIW processors" as that's how http://www.movidius.com/our-technology/myriad-2-platform/ describes them.

http://reviews.llvm.org/D10413

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list