[PATCH] [mips] [IAS] Add support for expanding LASym with a source register operand.
Daniel Sanders
daniel.sanders at imgtec.com
Fri Jun 12 08:32:54 PDT 2015
This version LGTM with a nit
================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:2012-2015
@@ -2009,2 +2011,6 @@
}
+
+ if (SrcReg != Mips::NoRegister)
+ createAddu(DstReg, DstReg, SrcReg, Instructions);
+
return false;
----------------
Nit: With this bit added we're not really loading a symbol address anymore, we're adding a symbol address and treating the $0 case as an optimization. I'd suggest hoisting this out into another function (addSymbolAddress()?) or renaming this function.
http://reviews.llvm.org/D9348
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list