[PATCH] [mips] [IAS] Add partial support for the ULW pseudo-instruction.
Daniel Sanders
daniel.sanders at imgtec.com
Fri Jun 12 06:34:36 PDT 2015
expandUlw() looks very similar to expandUlh(). Could we share code between them?
================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:2389-2394
@@ +2388,8 @@
+
+ // NOTE: We do this (D)ADDu here instead of doing it in loadImmediate()
+ // because it will make our output more similar to GAS'.
+ // NOTE: If there is no source register specified in the ULW, the parser
+ // will interpret it as $0.
+ if (SrcReg != Mips::ZERO && SrcReg != Mips::ZERO_64)
+ createAddu(ATReg, ATReg, SrcReg, Instructions);
+ }
----------------
Could you tell me the cases where this matters? loadImmediate() will usually emit the same thing here.
http://reviews.llvm.org/D9663
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list